Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workspace #251

Closed
wants to merge 6 commits into from
Closed

Update workspace #251

wants to merge 6 commits into from

Conversation

Qsppl
Copy link
Contributor

@Qsppl Qsppl commented Apr 8, 2024

I have enabled source code formatting to match the code style for VSCode.
Try Alt+Shift+F or Format file in the context menu, but don't forget to install the npm packages first.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 8, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@coveralls
Copy link

coveralls commented Apr 8, 2024 •
edited
Loading

Coverage Status

coverage: 99.955%. remained the same
when pulling ffd5e48 on Qsppl:update-workspace
into 429ec6f on hybridsjs:main.

smalluban
smalluban requested changes Apr 12, 2024
View reviewed changes
.prettierrc
"trailingComma": "all"
"trailingComma": "all",
"editorconfig": true,
"printWidth": 160
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a styling change, not additional metadata, which is suppose to help users using some editors. Please remove that change.

.editorconfig
@@ -0,0 +1,12 @@
# EditorConfig is awesome: https://EditorConfig.org
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is essentially not required at all, as the prettier does the job. You just need to enable it in your editor. I would rather add a suggestion for adding a prettier plugin for vs code (esbenp.prettier-vscode)

@smalluban smalluban force-pushed the main branch 3 times, most recently from 7b89169 to 97f8843 Compare June 13, 2024 06:59
@smalluban
Copy link
Contributor

As this PR is not going forward, and there are many changes in configuration, which in my opinion are not required, I am closing the PR.

Currently, if you use proper tooling in VS Code, the source code is automatically formatted. There is a npm run lint command, which protects from merging to main the code breaking the rules.

@smalluban smalluban closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smalluban smalluban smalluban requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qsppl @coveralls @smalluban